fix(clipboard): alt_text in write_html command not being passed with correct argument name
#2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasteiner
changed the title
alt_text in write_html command not being passed with correct argument namealt_text in write_html command not being passed with correct argument name
Package Changes Through e70466bThere are 18 changes which include fs with minor, upload with minor, upload-js with minor, updater with minor, clipboard-manager-js with patch, deep-link with patch, deep-link-js with patch, persisted-scope with minor, log-plugin with patch, log-js with patch, fs-js with patch, http with patch, localhost with minor, opener with major, opener-js with major, positioner-js with minor, positioner with minor, sql with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Nov 26, 2024
amrbashir
approved these changes
Nov 26, 2024
|
Sorry, it's my first time contributing here. |
|
Thank you |
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
…ith correct argument name (tauri-apps#2099)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the clipboard manager plugin, this is the writeHtml command:
plugins-workspace/plugins/clipboard-manager/src/commands.rs
Lines 65 to 72 in c665818
The fallback plaintext argument is called
alt_text.On the client side however the command is invoked like this:
plugins-workspace/plugins/clipboard-manager/guest-js/index.ts
Lines 123 to 128 in c665818
the alternative text is passed as
altHtml. This causes thealt_textargument to be always empty, resulting in an empty string to be copied into the clipboard.This PR...
renames the argument on the client-side to match that of the backend.